Skip to content

Add order by to make the rightness of group by integration test #13789

Merged
HTHou merged 1 commit intomasterfrom
fix_it
Oct 16, 2024
Merged

Add order by to make the rightness of group by integration test #13789
HTHou merged 1 commit intomasterfrom
fix_it

Conversation

@Beyyes
Copy link
Copy Markdown
Member

@Beyyes Beyyes commented Oct 16, 2024 •
edited
Loading

Description

As the title.

This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.
Key changed/added classes (or packages if there are too many classes) in this PR

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.84%. Comparing base (6510fb8) to head (601b1fe).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master   #13789   +/-   ##
=========================================
  Coverage     40.83%   40.84%           
  Complexity       71       71           
=========================================
  Files          4057     4057           
  Lines        254110   254110           
  Branches      31030    31030           
=========================================
+ Hits         103771   103782   +11     
+ Misses       150339   150328   -11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HTHou HTHou merged commit 0fe5698 into master Oct 16, 2024
@HTHou HTHou deleted the fix_it branch October 16, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HTHou HTHou HTHou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Beyyes @HTHou